Repository navigation
fix: add Strimzi KafkaTopic v1 and Istio EnvoyFilter v1alpha3 - #10
Merged
Merged
Conversation
The existing templates write apiVersions that current releases reject: - kafka.strimzi.io/v1beta2 KafkaTopic: Strimzi 1.0 removed every version older than v1, and Strimzi 1.3.0 only serves v1. - networking.istio.io/v1beta1 EnvoyFilter: Istio (checked 1.31.2) only serves EnvoyFilter as v1alpha3. Add the versions upstream serves. The old ones stay so existing users don't break, with a comment pointing at the new one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two add-on templates write an
apiVersionthat current releases of those projects reject:k8s['kafka.strimzi.io'].v1beta2.KafkaTopickafka.strimzi.io/v1beta2v1since Strimzi 1.0 (1.3.0 CRD)k8s['networking.istio.io'].v1beta1.EnvoyFilternetworking.istio.io/v1beta1v1alpha3(Istio 1.31.2 CRDs)This adds
k8s['kafka.strimzi.io'].v1.KafkaTopicandk8s['networking.istio.io'].v1alpha3.EnvoyFilter. The old templates stay so existing configs still evaluate, with a comment pointing at the new version.k8s.adoptpicks up the new versions too.Tests:
tests/k8s_test.jsonnetchecks the apiVersion of both new templates and thattypeForfinds them.just testpasses; the new asserts fail againstmain.🤖 Generated with Claude Code